Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow requests with omitted params field #3080

Closed
skunert opened this issue Jan 5, 2023 · 0 comments · May be fixed by #3090
Closed

Allow requests with omitted params field #3080

skunert opened this issue Jan 5, 2023 · 0 comments · May be fixed by #3090

Comments

@skunert
Copy link

skunert commented Jan 5, 2023

An issue was reported in cumulus where requests caused smoldot to crash because the params field is omitted in the JSON-RPC request paritytech/cumulus#2053 .

After looking at the JSON-RPC Spec it seems that the params field should be optional and Smoldot should accept requests without it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept JSON-RPC requests without a params field tomaka/substrate-lite-1
1 participant
@skunert