Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCM: Remove require_weight_at_most from Transact #4284

Open
franciscoaguirre opened this issue Apr 25, 2024 · 0 comments
Open

XCM: Remove require_weight_at_most from Transact #4284

franciscoaguirre opened this issue Apr 25, 2024 · 0 comments
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Apr 25, 2024 •
edited

The Transact instruction shouldn't need the require_weight_at_most parameter, since the decoder could just get the weight of the call from its dispatch info.

It might be difficult to estimate the weight needed for BuyExecution though.

Will probably have to go into XCMv5, to not break the format.
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Apr 25, 2024
@seadanda seadanda mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franciscoaguirre