Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bot fmt" + "bot clean" fails with HttpError because of removed comment #252

Open
ordian opened this issue Nov 24, 2023 · 1 comment
Open
Assignees

Comments

@ordian
Copy link
Member

ordian commented Nov 24, 2023

paritytech/polkadot-sdk#1841 (comment)

EDIT: but the command succeeded eventually.

{"issue_number":1841,"body":"@ordian https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4468802 was started for your command `\"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh\"`. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently. \n\nComment `bot cancel 20-879efa0a-9e37-42d1-93b7-e400fda1bc7f` to cancel this command or `bot cancel` to cancel all commands in this pull request."}

looks like a race condition with bot clean which probably removed the initial comment which bot have left with promise to update 🙈

The reason is the sequence.. if you place bot clean after the other command - it will be executed after the first comment posted - so the posted comment will be treated as "outdated".

Solution would be - check only the comments which were left by bot BEFORE the current set of commands in any of the sequence

@mordamax mordamax self-assigned this Nov 24, 2023
@mordamax
Copy link
Contributor

thanks @ordian for reporting
It's looks like a race condition with bot clean which probably removed the initial comment which bot have left with promise to update 🙈

@mordamax mordamax changed the title bot fmt fails with HttpError "bot fmt" + "bot clean" fails with HttpError because of removed comment Nov 24, 2023
@mordamax mordamax added the bug Something isn't working label Nov 24, 2023
@mordamax mordamax removed the bug Something isn't working label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants