Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to query QueryRange non-delta profiles buckets from FrostDB #2598

Open
metalmatze opened this issue Feb 15, 2023 · 0 comments · May be fixed by #3789
Open

Support to query QueryRange non-delta profiles buckets from FrostDB #2598

metalmatze opened this issue Feb 15, 2023 · 0 comments · May be fixed by #3789
Labels
area/storage Something about the storage enhancement New feature or request

Comments

@metalmatze
Copy link
Member

Most of the work needs to be done in FrostDB: polarsignals/frostdb#347

parca/pkg/parcacol/querier.go

Lines 571 to 579 in ed90dbe

// TODO: This still queries way too much data from the underlying database.
// This needs to be moved to FrostDB to not even query all of this data in the first place.
// With a scrape interval of 10s and a query range of 1d we'd query 8640 samples and at most return 960.
// Even worse for a week, we'd query 60480 samples and only return 1000.
tsBucket := ts / 1000 / int64(step.Seconds())
if _, found := resSeriesBuckets[index][tsBucket]; found {
// We already have a MetricsSample for this timestamp bucket, ignore it.
continue
}

This issue is mostly to keep track of updating Parca once the necessary parts have been implemented in FrostDB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/storage Something about the storage enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#2598): Support to query QueryRange non-delta profiles buckets from FrostDB albertlockett/parca
1 participant
@metalmatze