Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract node-core/init.rs from node-core #8171

Open
mattsse opened this issue May 8, 2024 · 1 comment · May be fixed by #8373
Open

extract node-core/init.rs from node-core #8171

mattsse opened this issue May 8, 2024 · 1 comment · May be fixed by #8373
Assignees
@willco-1
Labels
C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 8, 2024

Describe the feature

these operations are out of place here:

https://github.com/paradigmxyz/reth/blob/aa07257d3ba071188b7b7e372856b50be094e8ba/crates/node-core/src/init.rs

they also can't be included in any existing storage crates, like db/provider and should be moved to reth-db-{common,core,init,ops}. Any other naming ideas @Rjected ?
leaning towards reth-db-common

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started C-debt A section of code is hard to understand or change and removed S-needs-triage This issue needs to be labelled labels May 8, 2024
@wlawt
Copy link
Contributor

wlawt commented May 23, 2024 •
edited

is this still available? i can try to take a stab at it @mattsse @Rjected

@wlawt wlawt linked a pull request May 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willco-1 willco-1

Labels
C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: extract init from node-core wlawt/reth
3 participants
@mattsse @wlawt and others