Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move all alloy-compat code to a standalone module #8168

Closed
mattsse opened this issue May 8, 2024 · 1 comment
Closed

move all alloy-compat code to a standalone module #8168

mattsse opened this issue May 8, 2024 · 1 comment
Assignees
@guha-rahul
Labels
C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 8, 2024

Describe the feature

instead of having various:

reth/crates/primitives/src/block.rs

Lines 150 to 151 in d467744

#[cfg(feature = "alloy-compat")]
impl TryFrom<alloy_rpc_types::Block> for Block {

all of these should be moved into a single file that is feature gated

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started C-debt A section of code is hard to understand or change and removed S-needs-triage This issue needs to be labelled labels May 8, 2024
@guha-rahul
Copy link
Contributor

can i take it?

@guha-rahul guha-rahul mentioned this issue May 10, 2024
Merged
@mattsse mattsse closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guha-rahul guha-rahul

Labels
C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @guha-rahul