Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract layers module from rpc crate #8161

Closed
mattsse opened this issue May 8, 2024 · 1 comment · Fixed by #8163
Closed

Extract layers module from rpc crate #8161

mattsse opened this issue May 8, 2024 · 1 comment · Fixed by #8163
Assignees
@rupam-04
Labels
A-rpc Related to the RPC implementation C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 8, 2024

Describe the feature

These layers aren't used by the crate directly, only in rpc-builder, they don't even need any eth/reth types

https://github.com/paradigmxyz/reth/tree/bdb8238d79c383033a68cbeef8809c37a481e303/crates/rpc/rpc/src/layers

TODO

  • extract these types to a standalone crate rpc/rpc-layer or rpc/rpc-util

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A section of code is hard to understand or change A-rpc Related to the RPC implementation labels May 8, 2024
@rupam-04
Copy link
Contributor

rupam-04 commented May 8, 2024

Can I take this?

@rupam-04 rupam-04 mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rupam-04 rupam-04

Labels
A-rpc Related to the RPC implementation C-debt A section of code is hard to understand or change C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract layers module from rpc crate rupam-04/reth
2 participants
@mattsse @rupam-04