Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papaya-Locking optimizations #10

Open
SaschaKersken opened this issue Jul 16, 2015 · 1 comment
Open

Papaya-Locking optimizations #10

SaschaKersken opened this issue Jul 16, 2015 · 1 comment

Comments

@SaschaKersken
Copy link
Contributor

I have reviewed the locking system and in my opinion there are some points to optimize locking without loosing existing functionality but getting a great plus with just a little effort.

  • lockTypes: you should reserve a range of lock types for the papaya system to avoid side effects on later extensions
  • It is not possible to lock multiple elements. Working in several tabs is state of the art. A variable for the locking mode (single [default] or multiple) and minor modifications of the method setLock should work.
  • There is a need for a method to capture an existing lock. Security queries are the realm of the environment and don't need to be implemented in this class.
  • On logout all existing locks of the given session should be killed. (Are there any logout hooks at all ?)
  • With multiple locks you need a method to remove a single lock and probably a method to get a list of existing locks (by session and optionally by type).
@SaschaKersken
Copy link
Contributor Author

There is also no chance to get the locking timestamp. It could be important for a concurrent user to know how long a lock is used or at what time the lock was set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant