Migrate to independent Flatpak app #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also review some comments
Installation instruction in README needs to be reviewed after investigation
…rate-to-flatpak-app
…rate-to-flatpak-app
The following message is shown every time we change the selected pane from the left list or scrolling the right pane (pantheon-tweaks:2): Gtk-CRITICAL **: 22:56:16.419: _gtk_widget_get_preferred_size_for_size: assertion 'size >= -1' failed
From https://docs.flatpak.org/en/latest/conventions.html#application-ids: For some practical examples of bad IDs ... - `com.github.foo.Bar` or `com.gitlab.foo.Bar` While a project may be hosted on GitHub or GitLab it does not have any control over the `github.com` or `gitlab.com` domain. Instead you should use `io.github` or `io.gitlab` as shown above.
Just copied from Reco :-P
Seems like "Setting" category is blocklisted?
As recommended in https://docs.flathub.org/docs/for-app-authors/requirements/?manifest-language=yml#desktop-files: If you need to change the desktop file, use the command desktop-file-edit on a post installation rule.
As per https://docs.flathub.org/docs/for-app-authors/requirements/?manifest-language=yml#branches-and-runtimes: Applications must be built against an SDK that is itself hosted on Flathub. elementary SDK is not hosted on Flathub, so we need to use GNOME SDK and setup stylesheets and granite manually instead.
Conflicts: src/Tweaks.vala
|
@Philip-Scott Now it's ready. Would you test and review this PR? |
|
@Philip-Scott Would it be possible for you to review/test this branch? (or should I go ahead to merge it by myself…?) |
|
@Philip-Scott I'll merge this and try submitting to Flathub today. Please let me know at any time if you observed strange code or behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
Fixes #161
Fixes #5
I'll submit Tweaks to Flathub once this PR is merged.
(FYI) Inputs for Review
Changes Summary
File Changes Summary
switchboard-2.0from dependencies-plugprefix from translation related names-plugprefix from .pot file-plugprefix from .pot fileninja pantheon-tweaks-potcommand(pantheon-tweaks:2): Gtk-CRITICAL **: 22:56:16.419: _gtk_widget_get_preferred_size_for_size: assertion 'size >= -1' failedWorks Confirmation
flatpak run io.github.pantheon_tweaks.pantheon-tweaksblocks running Tweaks as expected on Ubuntu 23.04