site:delete exit status bug/enhancement

[chrisrrowland]

Platform

( ) MacOS
( ) Linux
(x) WSL2

Installed Via

I don't recall.

PHP Version

( ) 7.4x
( ) 8.0
(x) 8.1

Terminus Version

Terminus 3.2.2

Command Executed

terminus site:delete --no-interaction 478eae98-ad9f-4f76-a3f9-17ff652985c5
 [notice] You must downgrade your site to sandbox before deleting.

echo $?
0

Expected behavior

I expect a site:delete command that does not result in the site being deleted to return a non-zero exit status.

Actual behavior

Bug The command failed because the site plan needs to be changed to sandbox prior to deleting, but it returned a status (0) indicating success. It should have returned a non-zero status.

Feature Request Additionally I would request a new flag such as "--force" that will delete a site regardless of plan, so it's not necessary to implement this automation as a transactionless 2 step process.

[kporras07]

Tracking internally as BUGS-7938 and FEAT-1377