Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow:wait reports workflow is still running when it isn't #2521

Open
mattdaniel opened this issue Dec 13, 2023 · 1 comment
Open

workflow:wait reports workflow is still running when it isn't #2521

mattdaniel opened this issue Dec 13, 2023 · 1 comment

Comments

@mattdaniel
Copy link

mattdaniel commented Dec 13, 2023

Platform

(x) MacOS
( ) Linux
( ) WSL2

Installed Via

(x) Homebrew
( ) Apt Package
( ) Manually

PHP Version

( ) 7.4x
( ) 8.0
(x) 8.1

Terminus Version

3.3.0

Command Executed

terminus workflow:wait projectname.dev

Expected behavior

  • Expect the correct status to be returned, including something like [notice] Workflow succeeded and the process exiting if there is no workflow running.

Actual behavior

  • The command thinks that the latest workflow is still running, when it isn't and actually finished a long time ago.
  • Command repeatedly reports this incorrect info until the max time is reached.
  • Example output:
 [notice] Current workflow is 'Automated backup for the live environment'; waiting for 'Sync code on dev'
 [notice] Current workflow is 'Automated backup for the live environment'; waiting for 'Sync code on dev'
 [notice] Current workflow is 'Automated backup for the live environment'; waiting for 'Sync code on dev'
  • Also note above that the environment is referring to live, but 'dev' was specified in the command.
  • The workflow that workflow:wait believes is running, has been confirmed as finished both in the dashboard, or with terminus, e.g. terminus workflow:info:status projectname.dev (note the info below still seems to ignore the .dev environment requested):
 [notice] Showing latest workflow on projectname.
 -------------- --------------------------------------------- 
  Workflow ID    c768ec2e-99f8-11ee-b832-...        
  Environment    live                                         
  Workflow       Automated backup for the "live" environment  
  User           Pantheon                                     
  Status         succeeded                                    
  Started At     2023-12-13 20:47:08                          
  Finished At    2023-12-13 20:54:14                          
  Time Elapsed   427s                                         
 -------------- --------------------------------------------- 

Note: same behaviour happening in github actions using ubuntu, terminus-build-tools-plugin, and build:workflow:wait

@DarkteK
Copy link

DarkteK commented May 7, 2024

I'm currently having the same issue:

Calling terminus workflow:wait --start 1715097376 --max 500 -- my-env
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'
Notice: ] Current workflow is 'Sync code on my-env'; waiting for 'Sync code on my-env'

It never ends...
Any fix for this? please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants