Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If non-default value is passed for injectable param, rewriter throws SyntaxError #98

Open
cisaacstern opened this issue Aug 30, 2023 · 1 comment

Comments

@cisaacstern
Copy link
Member

As described in pangeo-forge/pangeo-forge-recipes#587 (comment). Per @yuvipanda's suggestion on the same thread, the rewriter should instead allow this type of manual override, and instead of raising an error, inject no value in this case.

@yuvipanda
Copy link
Collaborator

is where the fix should be. There should be a conditional - if the keyword already exists, we should choose to either first delete it, or ignore completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants