Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment error on new repo without pull requests #31

Open
jbusecke opened this issue Mar 22, 2024 · 2 comments
Open

Deployment error on new repo without pull requests #31

jbusecke opened this issue Mar 22, 2024 · 2 comments

Comments

@jbusecke
Copy link
Contributor

I just noticed a quirk with the deploy action for a brand new repo where the action was entirely triggered by pushes to main.

I was trying to separate a recipe example from a more mature and complex bakery repo and ran into this error.

assert len(pulls) == 1  # pretty sure this is always true, but just making sure

I think this line here basically fails because there is not a single PR in the repo yet (will test this in a minute). But just wanted to document this here.

@cisaacstern
Copy link
Member

Yes the error should presumably be more descriptive.

But in general I think this is the behavior we want?

Insofar as it ensures users are not deploying by pushing to main (but rather from PRs)?

@jbusecke
Copy link
Contributor Author

I think this is worth a broader discussion (pending some docs write up) as I have been going back and forth on how to actually launch recipes in multiple scenarios (see #33).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants