Added Typing #311
Added Typing #311
Conversation
|
Thanks! I've asked a colleague to provide a review. |
There was a problem hiding this comment.
Thank you for the great work @Siddhesh-Agarwal ! After review, here are my suggestions. I do not have the most experience with typing so please feel free to provide your input to the suggested changes.
|
@charlesgauthier-udm I have completed the changes mentioned in the previous review. I hope these are up to your expectations. |
Co-authored-by: Charles Gauthier <85585494+charlesgauthier-udm@users.noreply.github.com>
|
Please resolve the test failures then this is ready to merge. |
|
@huard, it is insane to have these many pre-commit hooks. Black, Isort, and flake8 seem fine but now prettier? I am sorry but I will have to leave this PR in this state. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Once installed locally, pre-commit will run before each commit, so this is not something you're expected to worry about and do "by-hand". I'm now working to address the remaining issues. I realized that by pushing to this PR, I'm pushing to your master, which might interfere with your work. Please open a PR in a separate branch to avoid this in the future. |
|
There are a couple of failures still remaining, but I'm stumped about what might cause them. |
isortfollowed byblackformatter