Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix possible wrong format guess if first element had May as month #58336

Closed
wants to merge 1 commit into from
Closed

BUG: Fix possible wrong format guess if first element had May as month #58336

wants to merge 1 commit into from

Conversation

Aloqeely
Copy link
Contributor

@Aloqeely Aloqeely mentioned this pull request Apr 20, 2024
Open
3 tasks
@matthew-brett
Copy link
Contributor

Nice! But - are there other languages / locales for which the abbreviated month is the same as the full month? How about Mai (French) for example? Can the test be generalized to find the first element for which full_month != abbrev_month somehow?

@Aloqeely
Copy link
Contributor Author

No clue how I would accomplish that without making the code even more complicated.
To be quite frank I did not even know you could pass dates in different languages than English and I would have no way of testing that

@Aloqeely
Copy link
Contributor Author

Going to close for now

@Aloqeely Aloqeely closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: incorrect assumption of full-name month format when "May" is initial month
2 participants
@Aloqeely @matthew-brett