New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Add frequency to DatetimeArray/TimedeltaArray take #58382
Open
annika-rudolph
wants to merge
5
commits into
pandas-dev:main
Choose a base branch
from
annika-rudolph:fix_get_level_values_gh_58327
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BUG: Add frequency to DatetimeArray/TimedeltaArray take #58382
annika-rudolph
wants to merge
5
commits into
pandas-dev:main
from
annika-rudolph:fix_get_level_values_gh_58327
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annika-rudolph
changed the title
Add take function to Datetime and TimedeltaArray (GH 57949 and GH 58327)
Add take function to Datetime and TimedeltaArray
Apr 23, 2024
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
2 times, most recently
from
April 25, 2024 08:22
19d396d
to
5440815
Compare
annika-rudolph
changed the title
Add take function to Datetime and TimedeltaArray
BUG: Add frequency to DatetimeIndex/TimedeltaIndex shallow copy
Apr 25, 2024
annika-rudolph
changed the title
BUG: Add frequency to DatetimeIndex/TimedeltaIndex shallow copy
BUG: Add frequency to DatetimeIndex/TimedeltaIndex _shallow_copy
Apr 25, 2024
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
April 25, 2024 11:27
30a69e1
to
30be34a
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
April 29, 2024 09:32
195a9a5
to
e67ca27
Compare
pandas/core/indexes/multi.py
Outdated
@@ -1244,7 +1244,9 @@ def _constructor(self) -> Callable[..., MultiIndex]: # type: ignore[override] | |||
return type(self).from_tuples | |||
|
|||
@doc(Index._shallow_copy) | |||
def _shallow_copy(self, values: np.ndarray, name=lib.no_default) -> MultiIndex: | |||
def _shallow_copy( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the options are doing this in take or shallow_copy, take is definitely preferred
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done -- implemented via take
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
April 30, 2024 15:19
d49d42c
to
b2a244a
Compare
annika-rudolph
changed the title
BUG: Add frequency to DatetimeIndex/TimedeltaIndex _shallow_copy
BUG: Add frequency to DatetimeArray/TimedeltaArray take
Apr 30, 2024
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
May 2, 2024 07:04
90a5c3f
to
cae8e63
Compare
annika-rudolph
force-pushed
the
fix_get_level_values_gh_58327
branch
from
May 3, 2024 07:49
cae8e63
to
ceb3633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Disclaimer
I am required to add that the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. In no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.