Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superscript/subscript tags broken by CSS #40

Open
nic-hartley opened this issue May 18, 2020 · 8 comments · May be fixed by #91
Open

Superscript/subscript tags broken by CSS #40

nic-hartley opened this issue May 18, 2020 · 8 comments · May be fixed by #91

Comments

@nic-hartley
Copy link

nic-hartley commented May 18, 2020 •
edited

I wanted to include superscript (<sup></sup>) in some text. The tag itself carries through, as expected, but the Slate theme includes this CSS reset (removed the other tags it affects, which AFAICT is all of them):

sup {
    margin: 0;
    padding: 0;
    border: 0;
    font: inherit;
        font-weight: inherit;
        font-size: inherit;
    vertical-align: baseline;
}

There's no corresponding re-setup for sup, so it ends up just looking like normal text.

One fix would be to add this to the bottom of the stylesheet:

sup {
    font-size: 65%;
    vertical-align: super;
    font-weight: bold;
}

...but of course that might need tweaking to fit better in the theme. I dunno, I'm not an artist. I just want my footnotes.

Another would be to remove sub from the reset, which would apply the browser-default styling.
@nic-hartley
Copy link
Author

After a quick glance, it appears sub will be broken in the same way. It'd be as simple a fix -- sub { ... vertical-align: sub; ... } instead of sup/super, but otherwise identical (with the same alternative option of just removing sub from the reset).

@nic-hartley nic-hartley changed the title Superscript tags broken by CSS Superscript/subscript tags broken by CSS May 18, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 18, 2020
@nic-hartley
Copy link
Author

This is still an issue, as far as I know. It would be nice to get it fixed so I can use superscript on Slate.

@stale stale bot removed the wontfix label Jul 20, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 20, 2020
@nic-hartley
Copy link
Author

Yeah, I've given up on this issue and the theme itself. Might submit a PR for Hacktoberfest, even though I'm now rolling my own.

@stale stale bot removed the wontfix label Sep 20, 2020
@snownontrace
Copy link

Thanks @nic-hartley -- your suggestions fixed my headache around superscripts!

b4rtz added a commit to Silobreaker/MaltegoDocumentation that referenced this issue Dec 3, 2020
@b4rtz
#11644 Fix footnotes for slate theme
79f0636 
* Fix based on solution found in gh issue : pages-themes/slate#40 (comment)
@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@nic-hartley
Copy link
Author

sigh

Disappointing to see how completely GitHub ignores issues which are trivially fixed, and it makes me wonder what other issues are being casually ignored.

@stale stale bot removed the wontfix label Jan 24, 2022
@rcowsill rcowsill linked a pull request Jan 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore sub/sup positioning rcowsill/jekyll-theme-slate
2 participants
@snownontrace @nic-hartley