Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis always gives error #60

Open
abdullahkavakli opened this issue Mar 31, 2021 · 5 comments
Open

Travis always gives error #60

abdullahkavakli opened this issue Mar 31, 2021 · 5 comments
Labels

Comments

@abdullahkavakli
Copy link

Like even here #59

@rdipardo
Copy link

rdipardo commented Apr 1, 2021

The problem is rubocop: https://travis-ci.org/github/pages-themes/slate/builds/765322596#L468

Just edit the .rubocop.yml file as shown here: #54

@abdullahkavakli
Copy link
Author

abdullahkavakli commented Apr 1, 2021

Thank you for your answer. It worked for my 2 requests: #58 and #57. But it din't here: #59. Can u explain why?

@rdipardo
Copy link

rdipardo commented Apr 1, 2021

No problem!
#59 failed because your markup used an illegal font-size value.
The CSS specification expects real numbers to be in North American decimal style, so change , to . in the style-sheet:

diff --git a/_sass/jekyll-theme-slate.scss b/_sass/jekyll-theme-slate.scss
index 5b244dc..414d488 100644
--- a/_sass/jekyll-theme-slate.scss
+++ b/_sass/jekyll-theme-slate.scss
@@ -418,7 +418,7 @@ Small Device Styles
   }

   code, pre {
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }
@@ -468,7 +468,7 @@ Small Device Styles
   code, pre {
     min-width: 240px;
     max-width: 320px;
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }

@abdullahkavakli
Copy link
Author

It worked. Thank you.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants