Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon support? #42

Open
seshrs opened this issue Sep 7, 2020 · 4 comments
Open

Favicon support? #42

seshrs opened this issue Sep 7, 2020 · 4 comments
Labels

Comments

@seshrs
Copy link

seshrs commented Sep 7, 2020

It would be nice if the Primer theme could add support for favicons. Spefically, it would be nice if default.html could add a <link rel="icon"> tag to the page if a favicon option is specified in _config.yml.

I first considered whether the Favicon should be included as part of the Jekyll SEO tag. However, I don't think the plugin should offer support for favicons, especially given its focus on generating machine-readable metadata for search engines and social networks.

I'm happy to open a PR to add favicon support — it should be extremely straightforward — but I wanted to ask for opinions before I do so. Comments and suggestions would be appreciated 😃

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 25, 2020
@seshrs
Copy link
Author

seshrs commented Dec 25, 2020

Bump on this. I’ll go ahead and open a PR too :)

@stale stale bot removed the wontfix label Dec 25, 2020
@MeesJ
Copy link

MeesJ commented Apr 18, 2021

This would be amazing!

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants