Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suddenly top menu bars are gone and replaced with blue icons? #42

Open
SkyperTHC opened this issue Nov 15, 2021 · 2 comments
Open

Suddenly top menu bars are gone and replaced with blue icons? #42

SkyperTHC opened this issue Nov 15, 2021 · 2 comments

Comments

@SkyperTHC
Copy link

SkyperTHC commented Nov 15, 2021

Hello,

I did not do anything for 8 month on my webpage and suddenly the pages (hosted on github) show a 'blue navigation bar' at the stop instead of the midnight navigation bar:
Screenshot 2021-11-15 at 13 19 55

It works fine on my jekyll (127.0.0.1:4000):
Screenshot 2021-11-15 at 18 38 55

Umm. How to fix this? I'm not a jekyll expert at all.

@SkyperTHC
Copy link
Author

i found the problem. Seems like the midnight theme had a major update. The version of the theme expected by github was not the version that I used to originally created the webpage. I thus re-installed the entire webpages and merged in all my changes into the latest version of the theme.

Thereafter I nailed it down (out of curiosity) and found that the culprit was in _layouts.default.html. The midnight that github expected needed {% include head-custom.html %} statement whereas the version that I was using did not have that statement.

I'm surprised that by github moving to a new midnight theme release that it would break existing pages...Is there a way to prevent this happening in the future? E.g. mark it as 'static' or so?

@Jiab77
Copy link

Jiab77 commented Nov 17, 2021

If I may add something, it seems to be like a missing <ul></ul> surrounding as said elsewhere. You can then decide to change your current CSS chain:

image

To: #header nav li.*

It should work but it will break the web standards... or you can restore the <ul></ul> tags that has been dropped in this commit.

Sorry, if I bothered you, just wanted to be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants