Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Add type checking and raise meaningful exceptions #271

Open
albscui opened this issue May 19, 2021 · 0 comments
Open

Add type checking and raise meaningful exceptions #271

albscui opened this issue May 19, 2021 · 0 comments

Comments

@albscui
Copy link

albscui commented May 19, 2021

Some of our client methods accept various types for inputs, for example in get_file(commit, path, URL), the commit can be a tuple, string, or Commit object. While we do some type checking with

def commit_from(src, allow_just_repo=False):
, but this might break for users that specified an invalid string, or a string that got the order of repo and commit wrong.

In general, we want to add type checking where possible, and raise meaningful exceptions when inputs are not valid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant