Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out of stack space using IE11 #660

Open
Valerio81 opened this issue Jan 23, 2020 · 0 comments
Open

out of stack space using IE11 #660

Valerio81 opened this issue Jan 23, 2020 · 0 comments

Comments

@Valerio81
Copy link

Your Environment

  • Version of highcharts-ng used: v1.2.2-dev
  • Browser Name and version: IE 11.592.18362.0
  • Operating System and version (desktop or mobile): Windows 10

Hi,
I've found a problem with IE11. When multiple charts was rendered, IE11 throw some "out of stack space" errors.

This is the JSFiddle with my code.

After some tests I think the problem is in "highcharts-ng" plugin in this function (row 103):

`
this.$doCheck = function () {
if (!detector(ctrl.config, prevConfig)) {
prevConfig = angular.merge({}, ctrl.config);
mergedConfig = getMergedOptions($element, ctrl.config, seriesId);

		//Remove any unlinked objects before adding
		this.removeUnlinkedObjects(mergedConfig);

		//Allows dynamic adding Axes
		this.addAnyNewAxes(mergedConfig.yAxis, ctrl.chart, false);
		this.addAnyNewAxes(mergedConfig.xAxis, ctrl.chart, true);

		//Allows dynamic adding of series
		if (mergedConfig.series) {
			// Add any new series
			angular.forEach(ctrl.config.series, function (s) {
				if (!ctrl.chart.get(s.id)) {
					ctrl.chart.addSeries(s);
				}
			});
		}

		ctrl.chart.update(mergedConfig, true);
	}
};

`

To avoid the problem i've modified the function adding

if (ctrl.disableChangeDetection === true) { return; }

after the first row.

Is possible to fix the problem avoiding my workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant