Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting some compilation errors (shadow variable, implicit cast) #99

Open
austinkinross opened this issue Feb 8, 2023 · 1 comment
Open

Comments

@austinkinross
Copy link

Hey, great project! FYI I'm hitting these errors when I try to compile it in our project, that has fairly strict MSVC warnings enabled:

tabulate\single_include\tabulate\tabulate.hpp(6005,40): error C2220: the following warning is treated as an error
tabulate\single_include\tabulate\tabulate.hpp(6005,40): warning C4800: Implicit conversion from 'int' to bool. Possible information loss
tabulate\single_include\tabulate\tabulate.hpp(6005,40): message : consider using explicit cast or comparison to 0 to avoid this warning
tabulate\single_include\tabulate\tabulate.hpp(8423,34): warning C4456: declaration of 'word_wrapped_text' hides previous local declaration
tabulate\single_include\tabulate\tabulate.hpp(8393,8): message : see declaration of 'word_wrapped_text'

I'm using top-of-tree master.

@cubicool
Copy link

cubicool commented Sep 1, 2023

Also seeing this. A patch like the one I've attached will make it compile, but these changes are by no means the "right" approach; the numeric sign issues are legit, potential problems.

tabulate.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants