Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(linter): react/require_render_return #3245

Closed
Boshen opened this issue May 12, 2024 · 1 comment · Fixed by #3276
Closed

perf(linter): react/require_render_return #3245

Boshen opened this issue May 12, 2024 · 1 comment · Fixed by #3276
Assignees
@mysteryven
Labels
A-linter Area - Linter C-bug Category - Bug C-performance Category - Solution not expected to change functional behavior, only performance

Comments

@Boshen
Copy link
Member

Boshen commented May 12, 2024 •
edited

react/require_render_return is slow

image

It seems like we need follow https://github.com/jsx-eslint/eslint-plugin-react/blob/master/lib/rules/require-render-return.js
@Boshen Boshen added C-bug Category - Bug A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels May 12, 2024
@Boshen
Copy link
Member Author

Boshen commented May 12, 2024

@mysteryven Do you wanna rewrite this?

@mysteryven mysteryven self-assigned this May 12, 2024
@mysteryven mysteryven mentioned this issue May 14, 2024
Merged
Boshen pushed a commit that referenced this issue May 15, 2024
@mysteryven
refactor(linter): rewrite react/require-render-return (#3276)
6128171 
Closes: #3245

It's gone now, curious about why didn't have performance improvement.

![CleanShot 2024-05-14 at 20 57
17@2x](https://github.com/oxc-project/oxc/assets/33973865/656ef8c6-65f7-4ce4-b8a1-4f3127bb6c36)

This picture generated by running all the rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mysteryven mysteryven

Labels
A-linter Area - Linter C-bug Category - Bug C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(linter): rewrite react/require-render-return oxc-project/oxc
2 participants
@Boshen @mysteryven