Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login user page stays in loop when it's disabled by the admin #10472

Closed
S-Panta opened this issue Feb 13, 2024 · 7 comments
Closed

Login user page stays in loop when it's disabled by the admin #10472

S-Panta opened this issue Feb 13, 2024 · 7 comments
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@S-Panta
Copy link
Contributor

S-Panta commented Feb 13, 2024

Describe the bug

When a user is disabled by the admin and if the user isn't logged out, the browser stays in the loop when trying to access it next time, and no login is possible.

Steps to reproduce

  1. Login with any test user
  2. Open incognito and login with admin and disable that user
  3. The user get logs out.

Expected behavior

It should be possible to log in to the URL again on that session

Actual behavior

The login page is stuck and it stays in the loop with the message Authentication failed. The browser console reads as getUser: user not found in storage.

image

@S-Panta S-Panta added the Type:Bug Something isn't working label Feb 13, 2024
@micbar
Copy link
Contributor

micbar commented Feb 13, 2024

@kulmann @rhafer

@micbar micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label Feb 13, 2024
@rhafer rhafer self-assigned this Feb 13, 2024
@rhafer
Copy link

rhafer commented Feb 13, 2024

@S-Panta I am not able to reproduce this. For me the disabled user is logged out successfully and after that I can login any other (not-disabled) user just fine using the same browser session.

Forget that I think I have a reproducer ...

@rhafer
Copy link

rhafer commented Feb 13, 2024

When the page is reloaded after a user got disabled, but before the access token is expired, the UI gets into a state where nobody can login anymore using that browser tab.

@kulmann I am transferring this to web as I am pretty sure this is a web issue.

@rhafer rhafer transferred this issue from owncloud/ocis Feb 13, 2024
@rhafer rhafer removed their assignment Feb 13, 2024
@kulmann kulmann added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels Feb 16, 2024
@JammingBen
Copy link
Collaborator

I suppose this is the same issue as #4677. The supposed fix #10165 has other drawbacks the last time I tested, so it needs a re-visit.

@S-Panta
Copy link
Contributor Author

S-Panta commented Mar 6, 2024

It looks similar though this is for disabled user.

@JammingBen
Copy link
Collaborator

It looks similar though this is for disabled user.

Yes. I think I didn't make myself clear enough 😄 What I meant was that the underlying technical issue with the IDP lib is (probably) the same, meaning fixing it will resolve both issues.

@S-Panta
Copy link
Contributor Author

S-Panta commented Mar 6, 2024

Closing this issue in favor of #4677

@S-Panta S-Panta closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants