Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New File in Sub Folder of Public Share cannot been created #8957

Closed
dj4oC opened this issue Apr 24, 2024 · 5 comments
Closed

New File in Sub Folder of Public Share cannot been created #8957

dj4oC opened this issue Apr 24, 2024 · 5 comments
Assignees
@rhafer
Labels
Interaction:Blue-Ticket Priority:p2-high Escalation, on top of current planning, release blocker Severity:sev3-medium minor loss of usage, workaround available Type:Bug

Comments

@dj4oC
Copy link
Contributor

dj4oC commented Apr 24, 2024 •
edited

Testing:
#8691

  1. Receive a Public Link of a folder
  2. Create a (sub-)folder
  3. Create a office file in that sub folder

Result: Failed to create file
Expected: File can been created

Workaround:

  1. Create a file on the received link "root" folder level.
  2. move the file into the created (sub-)folder

@micbar
\cc @wkloucek @d7oc @dragotin
@dj4oC dj4oC added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker Severity:sev3-medium minor loss of usage, workaround available labels Apr 24, 2024
@micbar
Copy link
Contributor

micbar commented Apr 24, 2024

Please provide more info about used ocis version and setup.

@micbar
Copy link
Contributor

micbar commented Apr 24, 2024

Severity is not possible because no blue ticket

@micbar micbar removed the Severity:sev3-medium minor loss of usage, workaround available label Apr 24, 2024
@phil-davis
Copy link
Contributor

@PrajwolAmatya @Salipa-Gurung
Please see if we have API test scenarios for this sort of thing - creating a sub-folder and uploading a file into it, for a read-write public link.

@micbar
Copy link
Contributor

micbar commented Apr 25, 2024

Note: create office file is not WebDAV, it it the app/new endpoint.

@rhafer rhafer self-assigned this Apr 25, 2024
@rhafer
Copy link
Contributor

rhafer commented Apr 25, 2024

I am able to reproduce. Seems to be yet another issue with the publicshare token scope verification 😭

rhafer added a commit to rhafer/reva that referenced this issue Apr 25, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
87097fd 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
@rhafer rhafer mentioned this issue Apr 25, 2024
Merged
rhafer added a commit to rhafer/reva that referenced this issue Apr 25, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
eb6b306 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
@dj4oC dj4oC added Interaction:Blue-Ticket Severity:sev3-medium minor loss of usage, workaround available labels Apr 25, 2024
rhafer added a commit to rhafer/reva that referenced this issue Apr 29, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
f3a000b 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
rhafer added a commit to cs3org/reva that referenced this issue Apr 29, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
5faad8d 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
rhafer added a commit to rhafer/reva that referenced this issue Apr 29, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
2cee2db 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
(cherry picked from commit 5faad8d)
@rhafer rhafer mentioned this issue Apr 29, 2024
Merged
rhafer added a commit to rhafer/reva that referenced this issue Apr 29, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
d2deee7 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
(cherry picked from commit 5faad8d)
rhafer added a commit to cs3org/reva that referenced this issue Apr 29, 2024
@rhafer
fix(auth/scope): fix nested resource check when creating a new resource
ddd52b1 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
(cherry picked from commit 5faad8d)
@rhafer rhafer mentioned this issue Apr 29, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Apr 29, 2024
@rhafer
bump reva to latest edge
b8ba402 
Fixes: owncloud#8957
@rhafer rhafer closed this as completed in 5a13179 Apr 29, 2024
ownclouders pushed a commit that referenced this issue Apr 29, 2024
@rhafer
bump reva to latest edge
70db255 
Fixes: #8957
nirajacharya2 pushed a commit to JankariTech/reva that referenced this issue Apr 30, 2024
@rhafer @nirajacharya2
fix(auth/scope): fix nested resource check when creating a new resource
2e867bd 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
aduffeck pushed a commit to aduffeck/reva that referenced this issue May 7, 2024
@rhafer @aduffeck
fix(auth/scope): fix nested resource check when creating a new resource
18ef17d 
When creating a reource (e.g a document via the app/new endpoint) below a next
folder structure of a public link, we can't stat the resource itself (it
doesn't exit yet) for checking if it is a descendant of the share root.
We now stat the resource's parent instead in that case.

Fixes: owncloud/ocis#8957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Interaction:Blue-Ticket Priority:p2-high Escalation, on top of current planning, release blocker Severity:sev3-medium minor loss of usage, workaround available Type:Bug
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhafer @phil-davis @micbar @dj4oC