Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize drone.star file #8794

Closed
10 tasks done
amrita-shrestha opened this issue Apr 8, 2024 · 10 comments
Closed
10 tasks done

Optimize drone.star file #8794

amrita-shrestha opened this issue Apr 8, 2024 · 10 comments
Assignees
Labels

Comments

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Apr 8, 2024

Describe the bug

There are several areas where optimization can be applied to the drone. While I've highlighted some points, please continue to explore additional areas where optimization is needed during the process.

IMO opinion we need to split shareng tests in 2 parts as you can see it crossing 15 min and still there are ongoing PR which adds tests on shreng
- one way to split is separate tests of sharing space using root endpoint in separate folder
@saw-jan any idea about this or we don't need to split ❓

Screenshot from 2024-04-08 12-57-48

@individual-it
Copy link
Member

After discussing with @ScharfViktor I've added an other todo item to change the destination of the notifications

@saw-jan
Copy link
Member

saw-jan commented Apr 11, 2024

After discussing with @ScharfViktor I've added an other todo item to change the destination of the notifications

Dev team might miss the ocis builds status so should we move to builds channel?

@individual-it
Copy link
Member

This is to reduce the noise. What about putting the normal builds into the ocis channel and only the nightly into builds?

@saw-jan
Copy link
Member

saw-jan commented Apr 11, 2024

This is to reduce the noise. What about putting the normal builds into the ocis channel and only the nightly into builds?

sounds good to me

@PrajwolAmatya
Copy link
Contributor

  • manage pipeline time to minimize overall time to finish build

Current CI takes less than 30 minutes to complete. Likewise, each pipeline completes within 15 minutes or less. Of all the localApiTests, localApiTests-apiSpacesShares-ocis takes more time to complete, roughly around 15 min, as it contains the most number of scenarios, 404 scenarios and 4421 steps. The time seems to be relevant, but we should keep monitoring the time of completion of every pipelines and overall time of completion of CI.

@saw-jan
Copy link
Member

saw-jan commented Apr 18, 2024

Let's close the issue as done.

CC @amrita-shrestha

@saw-jan
Copy link
Member

saw-jan commented Apr 30, 2024

  • make return type similar to maintain standard (some returns dict data type where some returns list)

Let's make all functions that return step or pipeline return list ([{...}])

@saw-jan
Copy link
Member

saw-jan commented May 14, 2024

IMO opinion we need to split shareng tests in 2 parts as you can see it crossing 15 min and still there are ongoing PR which adds tests on shreng

  • one way to split is separate tests of sharing space using root endpoint in separate folder
    @saw-jan any idea about this or we don't need to split ❓

better to split the apiSharingNg into two or more suites (features grouped accordingly)

@saw-jan
Copy link
Member

saw-jan commented May 17, 2024

@PrajwolAmatya Can we close this one?

@PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya Can we close this one?

With the changes, the CI completes inside 30 mins. But, regular inspection would be needed for the CI run time. As all the tasks in this issue has been covered, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants