Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Sharing NG #7932

Open
micbar opened this issue Dec 11, 2023 · 3 comments
Open

[QA] Sharing NG #7932

micbar opened this issue Dec 11, 2023 · 3 comments

Comments

@micbar
Copy link
Contributor

micbar commented Dec 11, 2023

Organisational overview of all QA

Related to #6993

Prerequisites

Start ocis with the default config.

  1. Resharing is controlled by OCIS_ENABLE_RESHARING

Recommendation: Decide before you deploy, if you change it, the existing Shares will not be converted.

New User / Group Lookup

Regular users can search for other users and groups. The following limitations
apply:

  • Only search queries are allowed (using the $search=term query parameter)
  • The search term needs to have at least 3 characters
  • for user searches the result set only contains the attributes displayName,
    userType, mail and id
  • for group searches the result set only contains the attributes displayName,
    groupTypes and id

Referencing #7782 for the qa team.

Collecting bugs:

@ScharfViktor
Copy link
Contributor

After discussion with @individual-it we decided to implement the new sharing ng tests separately from the existing api tests.

adapting new api to existing tests can be complicated and slow down test development.

so we need:

  1. create a new ApiShare suite with LinkContext.php ShareContext.php and using existing graphHelper.php

  2. start to write tests for this endpoinds:
    https://owncloud.dev/libre-graph-api/#/roleManagement
    https://owncloud.dev/libre-graph-api/#/drives.permissions

  3. reuse existing cases but don't delete old tests (we'll delete them after 6 months)

  4. pay attention to permissions, security stuff (negative cases when an unauthorized or unauthorized user tries to do something)

  5. use wording appropriate to the api request like user gets sharing permissions for a file|folder

also for https://github.com/owncloud/cs3api-validator need create some positive CRUD tests:

  • create sharing invitation with all roles and all existing permissions
  • create sharing link with all roles and all existing permissions, custom name and expirity

@ScharfViktor
Copy link
Contributor

First test already created: #7946
cc @individual-it @saw-jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants