share_with_user_type is not set in response

[phil-davis]

This was introduced in oC10 core owncloud/core#40013 and needs to be added to oCIS-reva

[micbar]

@phil-davis @kulmann What is the use case of that property?

[phil-davis]

@phil-davis @kulmann What is the use case of that property?

It helps clients to be able to know if the share receiver (sharee) is a real user or a guest user. If "guest" users do not exist in oCIS it will make no difference, but it could be added and would always be the "user" value at the moment on oCIS.

Docs issue owncloud/docs-server#272
"we emit a new field called share_with_user_type which might either be 0 = user or 1 = guest"

So it could be set to "0".

Note: I raise these issues so that an issue exists in case some test scenario from oC10 core fails, that makes it easy for the difference to be linked to an issue in expected-failures, which can then be discussed (like is happening here)

[kulmann]

There are two occurences of that field. One in ocs sharee query responses so that we know which type of user we're dealing with when inviting people. That's probably needed for ocis/reva as well if we don't come up with an entirely different guest sharing solution.

For the ocs share(s) endpoints it would be better if we emit the proper guest share type (4 instead of 0) for guest shares. The user type for shares is only used in the sdk (api abstraction layer) to rewrite shares with type 0 and user type 1 to guest shares (type 4). So it's a workaround in oc10, where we didn't want to take the chance of compromising other pieces of code that rely in a share type 0 for guest shares.

[kulmann]

Wouldn't hurt to emit the user type of the share as well, but it's not needed for web so I would not wxpect it to be added as long as we get proper guest share types.