Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed as navigation sidebar entry in files app #727

Open
8 tasks
PVince81 opened this issue Sep 7, 2017 · 4 comments
Open
8 tasks

Embed as navigation sidebar entry in files app #727

PVince81 opened this issue Sep 7, 2017 · 4 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 7, 2017

Instead of being a standalone page, make the gallery part of the files app by having it be an additional entry in the left navigation pane.

Now the best would rather to have any files view be switchable to gallery mode, but doing so would be way more complicated, see owncloud/core#17357.

So to make at least a little step forward, having the gallery file list appear from a "Gallery" entry in the left navigation pane comes with a few advantages:

  • ability to integrate with the existing files sidebar (which we'll need anyway)
    • removal of custom sharing code
    • removal of custom upload code

Todos:

  • remove app navigation entry
  • register as files app section
  • integrate with regular file list events where needed
  • make sure upload still works: either keep the current one or somehow integrate with the one from the files app
  • sidebar related events:
    • trigger proper events for the sidebar to open
    • trigger events for sidebar content refresh
    • react on some events triggered by the sidebar like when a file has being shared ? (only if necessary)
@mmattel
Copy link
Contributor

mmattel commented Sep 7, 2017

Q: for this big step, why not also thinking about changing from user based thumbnail store to a centralized thumbnail store ?
Lets say you have 20k pictures and share the repository with a group of 100 people
Current 20k thumbs * 100 == a lot of space needed
Future 20k thumbs *1 == much less space needed

I can tell from own experience that for 20k pictures you end up in GB of thumbs. Minimizing space consumption is a topic, especially in professional environments.

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 7, 2017

@mmattel please make a separate issue for this.

The embedding above is a pure JS / frontend effort and doesn't touch anything related to thumbnails.

@mmattel
Copy link
Contributor

mmattel commented Sep 7, 2017

ok thanks, will do

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 7, 2017

@mmattel regarding thumbsnails, I seem to remember that there was a core ticket somewhere to make thumbnails common to users. The only trouble was with encryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants