Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.cookie.samesite inconsistency #349

Open
2 of 12 tasks
mmattel opened this issue May 17, 2022 · 3 comments
Open
2 of 12 tasks

http.cookie.samesite inconsistency #349

mmattel opened this issue May 17, 2022 · 3 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented May 17, 2022

WHAT Needs to be Documented?

When looking to several documents like OIDC, Azure and MS-OFFICE-WOPI the http.cookie.samesite shows different values which are not consistent - this may confuse readers. Used values are none and lax.

We should agree on one value and note if possible an alternative one.

WHERE Does This Need To Be Documented (Link)?

WHY Should This Change Be Made?

Reduce Confusion

(Optional) What Type Of Content Change Is This?

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

(Optional) Which Manual Does This Relate To?

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other

@tbsbdr @DeepDiver1975

@DeepDiver1975
Copy link
Member

There is no inconsistency here.

If one only uses wopi - 'lax' is enough
For OpenID 'none' is required

Values for samesite (ordered from highest to lowest strictness): strict, lax, none

@mmattel
Copy link
Contributor Author

mmattel commented May 17, 2022

What happens if you use OpenID AND WOPI.
Is it ok to use none and does this no harm to wopi?
There is no mentioning about this and this needs to be clarified
Maybe you know having a good insight, but this is docs where readers have a different background. Can you advise?

@DeepDiver1975
Copy link
Member

What happens if you use OpenID AND WOPI.

you need to use the lowest strictness which is 'none'

this is plain logic which everybody should be capable to follow:

  • use strict whenever possible
  • if necessary relax to 'lax'
  • if it needs to be relaxed even further: use 'none'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants