[QA] login fails with IE11, syntax error in sharedialogview.js

[jnweiger]

Seen with 10.13.0-rc.1 and Internet Explorer 11 (Microsoft Windows version 1809)

When trying to log in, at the web UI, the login is denied with the message
"You took too long to log in, please try again now"

This error message is wrong. I can type very fast, it always occurs.
The real problem seems to be with javascript syntax. The browser console shows:

occ app:disable files_mediaviewer removes the second error, but login still fails the same.

[jnweiger]

workaround: use edge (on the same old win10)

[jnweiger]

This seems to be a regression. With 10.12.2 the login works:

[hodyroff]

We didn't deprecate IE support. We wanted to maintain it, can we do a fix? Propably coming from the JS fixes?
@fschade or delegate

[jnweiger]

Ah, more details:

• with a freshly booted windows, the login works.
• when the user clicks the share icon of a file or folder, the sharing sidebar opens blank.
• thereafter the user is being kicked out, and can no longer log in with the above message.

[fschade]

@grimmoc, if i remember right you have a windows installation, can you have a look?

[JammingBen]

The error seems to be in sharedialogview.js. Since this was working in 10.12.2, it must have been due to some recent changes. I stumbled upon this commit: https://github.com/owncloud/core/pull/40886/files#diff-32a9288d49d563b83dd8bab064e9aa35a9f3c8f0aa0321bf1b61089d9c82ea5a. It doesn't change much in that file, but it includes this:

let showIcon = false;
let iconClass = ""

I remember having some compatibility issues when using let or const in oC10. I guess this is the problem and we need to use var instead. I can't get IE running on my Mac though to verify this. @grimmoc I could help you with setting up oC10 to check.

[grimmoc]

Yes, IE11 doesn't support ES2015, which includes support for let and const. var must be used instead. On my Win 10 machine I cannot open a regular IE11 any more since it will always redirect to MS Edge instead. There's a IE legacy mode in Edge which however seems to implement support for ES2015. I ran a test file "test.html" containing const a = 'hello'; alert(a); and it would show a message box containing "hello" as (not) expected. I think a Windows version prior to 20H2 must be used to get access to the old IE. I mean, seriously, who is still using that tho?

[jnweiger]

Do you also have a cure for the problem with files_mediaviewer_init.js ?

[JammingBen]

Do you also have a cure for the problem with files_mediaviewer_init.js ?

I feel like that needs some debugging. After a first glance at the code: is this a new problem? It looks to me as if the app has never been compatible with IE. Last change to src has been made over 2 years ago... or did some dependency bump cause this?!

[jnweiger]

Ah, nevermind, this is a known issue since 2021: owncloud/files_mediaviewer#355

[JammingBen]

Then I'm closing here since #40934 has been merged.

[jnweiger]

Confirmed fixed in 10.13.0-rc.2
Still some random logouts occur. But nothing in the debug console.