Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New offline embed has overflow problems #3683

Open
gabek opened this issue Apr 11, 2024 · 3 comments
Open

New offline embed has overflow problems #3683

gabek opened this issue Apr 11, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site

Comments

@gabek
Copy link
Member

gabek commented Apr 11, 2024

Share your bug report, feature request, or comment.

image

@gabek gabek added bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site labels Apr 11, 2024
Copy link

Good First Issue

This item was marked as a good first issue because of the following:

  • It's self contained as a single feature or change.
  • Is clear when it's complete.
  • You do not need deep knowledge of Owncast to accomplish it.

Next Steps

  1. Comment on this issue before starting work so it can be assigned to you. Also, this issue may have been filed with limited detail or changes may have occurred that are worth sharing with you before you start work.
  2. Drop by our community chat if you'd like to be involved in more real-time discussion around Owncast to talk about this change.
  3. Follow the project's getting started tips to make sure you can build and run the project from source.

Notes

  • Development takes place on the develop branch.
  • We use Storybook for testing and developing React components. npm run storybook. A hosted version is available for viewing.
  • If you need to install the Go programming language to run the Owncast backend it's simple from here.
  • Active contributors get an Owncast t-shirt! Ask about it if you feel like you've been contributing and haven't yet been given one.

New to Git?

If you're brand new to Git you may want a short primer about the Fork -> Commit -> Pull Request workflow that enables changes to get made collaboratively using git. Visit the First Contributions project to learn step-by-step how to commit a change to a Git repository such as this one.

@Jeetch8
Copy link
Contributor

Jeetch8 commented Apr 11, 2024

@gabek Can you please explain what element is overflowing ?
Is it the input field ?

@gabek
Copy link
Member Author

gabek commented Apr 11, 2024

You can see the top of the text and the bottom button get cut off in the above screenshot when the description text is very long and/or when the follow textbox is shown. Perhaps we need to both set a max height for the description text, and hide it when showing the follow text box.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Web frontend Issues dealing with the web site
Projects
None yet
Development

No branches or pull requests

2 participants