New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add server-side caching for requests that could benefit #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabek
force-pushed
the
gek/server-side-caching
branch
from
December 4, 2023 16:10
9d95a2f
to
5bc46af
Compare
This was
linked to
issues
Dec 8, 2023
Passing run #12121 ↗︎
Details:
Review all test suite changes for PR #3463 ↗︎ |
Passing run #12119 ↗︎
Details:
Review all test suite changes for PR #3463 ↗︎ |
gabek
force-pushed
the
gek/server-side-caching
branch
from
December 10, 2023 00:07
89ef9a7
to
350e435
Compare
gabek
force-pushed
the
gek/server-side-caching
branch
from
December 10, 2023 00:12
350e435
to
6b551fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thought here is to keep a server-side cache for web responses that change rarely, or are timed. This should improve web performance when getting hit with requests around the same time.
Testing required.