Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of SKIPPED_TESTS in e2e-cp.sh #4229

Open
kyrtapz opened this issue Mar 15, 2024 · 3 comments
Open

Improve handling of SKIPPED_TESTS in e2e-cp.sh #4229

kyrtapz opened this issue Mar 15, 2024 · 3 comments
Assignees
Labels
e2e-testing good first issue Issues new contributors can pick up

Comments

@kyrtapz
Copy link
Contributor

kyrtapz commented Mar 15, 2024

Improve how we handle skipped tests in e2e-cp.sh.
Currently the SKIPPED_TESTS is a variable that we add "|test" to, this is error prone and can cause us skipping tests unintentionally.
Example bug: #4227

@kyrtapz kyrtapz added good first issue Issues new contributors can pick up e2e-testing labels Mar 15, 2024
@tssurya
Copy link
Member

tssurya commented Apr 4, 2024

another example: #4253

@jluhrsen
Copy link
Contributor

jluhrsen commented Apr 4, 2024

@kyrtapz , @tssurya , do you have any specific ideas or examples to do this better? I'd like to work on this if possible. I can dig in and come up with my own idea if you don't have anything off the top of your head.

@jluhrsen jluhrsen self-assigned this Apr 4, 2024
@tssurya
Copy link
Member

tssurya commented May 17, 2024

@jluhrsen : go wild and reinvent this :) I don't have any specific preference but can we see how K8s/K8s does these things just to get some motivation maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-testing good first issue Issues new contributors can pick up
Projects
None yet
Development

No branches or pull requests

3 participants