Skip to content
This repository has been archived by the owner on Aug 6, 2021. It is now read-only.

Redirect to Login Mask for Read Only Users #760

Closed
cmprmsd opened this issue Mar 16, 2021 · 4 comments
Closed

Redirect to Login Mask for Read Only Users #760

cmprmsd opened this issue Mar 16, 2021 · 4 comments

Comments

@cmprmsd
Copy link

cmprmsd commented Mar 16, 2021

Steps to Reproduce

  1. Create a LaTeX document
  2. Invite someone with "Read Only" permissions
  3. Accept the invite and open the report as invited user

Expected Behaviour

The page should now redirect you to the report and view it.

Observed Behaviour

The user will see the loading Overleaf icon and then there is a redirect to the login mask, although the user is logged in.

Context

Users cannot see the document I want them to be able to see.

Technical Info

I'm using the dockerized version with nginx and websockets enabled.

@cmprmsd
Copy link
Author

cmprmsd commented Apr 12, 2021

Hey,
I have not heard back yet.
We're going to troubleshoot the issue this week at our work.

If you have any ideas, what's causing the redirect, feel free to share :)

@cmprmsd
Copy link
Author

cmprmsd commented Apr 13, 2021

Following up the analysis of this problem. I still do not understand the reason for this redirect.

When I open a page with read only permissions I can see the project in my shared projects.
Once I open it, the page loads and immediately redirects me to a login form:
image

As you can see, I am still logged in, as the head navigation shows projects and account as well as my defails when I click on Account.

In BurpSuite the traffic looks like this:
image
I load the page, there is no redirect, but my client requests the login page and displays it after seeing its first 403 forbidden.

This seems to be a permission issue with ReadOnly projects. I think this has to be fixed on the web server code as I sometimes manage to break the redirect request and have the page loaded correctly.

I think the problem resides in the servers response the request before (/folder):

 {"message":"restricted"}

I can change the response code from 403 Forbidden to 200 OK and the content to

{"message":"OKI"}

which causes the client to load fine. Help :)

@paulojreis Maybe you have an idea!

@cmprmsd
Copy link
Author

cmprmsd commented Jun 1, 2021

Hi,

Can you please have a look here? I'd really like to close this issue with the cause fixed.

@das7pad
Copy link
Member

das7pad commented Aug 6, 2021

Hi!

Thank you for taking the time to write up this issue.

We are in the process of migrating to a monorepo at https://github.com/overleaf/overleaf and will mark this repository read-only soon.
You can read more about the monorepo migration at overleaf/overleaf#923.

We are going to close this issue now to avoid any confusion about the inability to comment further.

If you believe this issue still needs addressing, please create a new issue at https://github.com/overleaf/overleaf.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants