fix: do not fail on start when there are no persistent volume claims #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snglth
force-pushed
the
k8s-no-volumes-no-fail
branch
from
79af2da
to
8c798ed
Compare
| ) | ||
| # Create volumes if exists | ||
| volumes_manifest = tutor_env.pathjoin(context.root, "k8s/volumes.yml") | ||
| volumes_content = pathlib.Path(volumes_manifest).read_text() |
There was a problem hiding this comment.
any particular reason for using Path here instead of open()?
There was a problem hiding this comment.
Just for brevity. Should I reimplement it using open()?
There was a problem hiding this comment.
Tutor code is using open or io.open. It is better to keep the new code consistent with the existing pattern rather than having a new one. Thanks
tutor/commands/k8s.py
Outdated
| "--selector", | ||
| "app.kubernetes.io/component=volume", | ||
| ) | ||
| # Create volumes if exists |
There was a problem hiding this comment.
nit: this comment can be updated to highlight when volumes are not created or vice versa.
snglth
force-pushed
the
k8s-no-volumes-no-fail
branch
from
8c798ed
to
2e206f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1030
My solution seems dirty to me, so I'm very much open to suggestions on how to improve it.