Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling introspection results in an error #1109

Open
Luca-Marra opened this issue Mar 15, 2023 · 1 comment
Open

Disabling introspection results in an error #1109

Luca-Marra opened this issue Mar 15, 2023 · 1 comment

Comments

@Luca-Marra
Copy link

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Version/Branch 0.15.2

Disabling the introspection:

overblog_graphql:
    security:
        enable_introspection: false

results to the following error:

request.CRITICAL: Uncaught PHP Exception Error: "Class "Overblog\GraphQLBundle\__DEFINITIONS__\QueryType" not found" at /app/vendor/overblog/graphql-bundle/src/Definition/Builder/TypeFactory.php

@fp-cfr
Copy link

fp-cfr commented Mar 16, 2023

Same here with v0.14.4 with the following Exception:

"Too few arguments to function GraphQL\Validator\Rules\DisableIntrospection::__construct(), 0 passed in /.../vendor/overblog/graphql-bundle/src/Request/Executor.php on line 128 and exactly 1 expected"

The problem is that in the master branch this issues was fixed here by @mcg-web 2cf6f48
but in the v.0.14 and v.0.15 branches this was never applied.
The webonyx part was commited 2 years ago https://github.com/webonyx/graphql-php/blame/e8dfe9b6a333578f4420294a62c25d951617fec3/src/Validator/Rules/DisableIntrospection.php#L16.

Here is the code with the latest tags.
v.0.14 https://github.com/overblog/GraphQLBundle/blob/v0.14.4/src/Request/Executor.php#L128
v.0.15 https://github.com/overblog/GraphQLBundle/blob/v0.15.2/src/Request/Executor.php#L128

I ask myself why this has not been noticed in all these years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants