Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSV v1.0.0 is missing a canonical URL #139

Closed
joshbuker opened this issue Mar 29, 2023 · 3 comments
Closed

OSV v1.0.0 is missing a canonical URL #139

joshbuker opened this issue Mar 29, 2023 · 3 comments

Comments

@joshbuker
Copy link
Contributor

joshbuker commented Mar 29, 2023

Discovered this while discussing #132

Currently, the canonical url for the schema is:
https://raw.githubusercontent.com/ossf/osv-schema/v<SEMVER>/validation/schema.json

For example, 1.4.0 resolves to:
https://raw.githubusercontent.com/ossf/osv-schema/v1.4.0/validation/schema.json

1.0.0 is historically important due to schema_version being null is implied to be 1.0.0, however currently that 404s:
https://raw.githubusercontent.com/ossf/osv-schema/v1.0.0/validation/schema.json

This should be added or backported so that it is consistent and can be used by validators.

@andrewpollock
Copy link
Contributor

Looks like this is a case of releasing https://github.com/ossf/osv-schema/releases/tag/1.0.0

@oliverchang
Copy link
Contributor

I've made a v1.0.0 release and https://raw.githubusercontent.com/ossf/osv-schema/v1.0.0/validation/schema.json now works.

@puerco
Copy link
Member

puerco commented May 15, 2024

A v1.0.0 release always warrants one or more beers 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants