Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring nbtsort-xx.c for maintenability #106

Open
mikecaat opened this issue Jun 10, 2021 · 2 comments
Open

Refactoring nbtsort-xx.c for maintenability #106

mikecaat opened this issue Jun 10, 2021 · 2 comments

Comments

@mikecaat
Copy link
Contributor

mikecaat commented Jun 10, 2021

pg_bulkload has codes related to nbtsort in "lib/nbtree/nbtsort-XX.c", which XX is each postgresql's version. And it has both postgresql's code and functions for only pg_bulkloads.

For maintenability, it's better to refactor "nbtsort-XX.c" and become "nbtsort-XX.c" to be just a copy of PostgreSQL's "src/backend/access/nbtree/nbtsort.c". So, this issue handles the followings.

  • If there are functions for only pg_bulkload in "lib/nbtree/nbtsort-XX.c", move the functions to "lib/nbtree/nbtsort-common.c"
  • Copy PostgreSQL's latest stable "src/backend/access/nbtree/nbtsort.c" to "lib/nbtree/nbtsort-XX.c"
@yanmeisun
Copy link
Contributor

Dear @mikecaat
I create a PR #110 to do it. Could you please review it?
By the way, since PostgreSQL version under 9.5 has been EOL, I am doing nothing to nbtsort-8.3.c ~ nbtsort-9.5.c.

@mikecaat
Copy link
Contributor Author

mikecaat commented Aug 2, 2021

Thanks a lot!

I agree that the under 9.6(?) has been EOL, so it's ok doing nothing to nbtsort-8.3.c ~ nbtsort-9.5.c.
I have a comment to the PR. Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants