Fix ignition-math6 #1910
Closed
Fix ignition-math6 #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the ignition-math6 formula currently fails with:
CMake Error at /home/linuxbrew/.linuxbrew/share/cmake/pybind11/pybind11NewTools.cmake:207 (python3_add_library):
Unknown CMake command "python3_add_library".
This adds a patch that is a mini version of an upstream PR that fixes
the build.
Fixes: osrf#1872
This modifies the ignition-math6 formula to use the homebrew python3.9. Without this, cmake will find and the highest available version of python which may not be the homebrew version.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
FYI, in the future, we also need to add |
|
my apologies for not reviewing this earlier. I take it this is intended to fix the formula when using linuxbrew? this pull request has conflicts; are you able to resolve them? |
|
I'm no longer using this software. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1872 and forces use of the homebrew python.
See individual commit messages for more details.