Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'a0' in LiftDragPlugin does not obey the aerodynamics habbits. #116

Open
petertheprocess opened this issue Aug 24, 2020 · 0 comments
Open

Comments

@petertheprocess
Copy link

https://github.com/osrf/gazebo/blob/a9f093f2fc7fa7fc49efa73719f6536ad28f8af7/plugins/LiftDragPlugin.cc#L254-L255
https://github.com/osrf/gazebo/blob/a9f093f2fc7fa7fc49efa73719f6536ad28f8af7/plugins/LiftDragPlugin.cc#L272-L274
For people who know aerodynamics, 'a0' can be easily misunderstood as 'Zero-Lift AOA' which is just the opposite number of present definition.
So I suggest changing the code like this.

this->alpha =  acos(cosAlpha) - this->alpha0; 

And we should update the tutorial of the plugin.

gazebosim/gazebo-classic#2831 (comment)
PX4/PX4-SITL_gazebo-classic#586 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant