Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on gazebo.materials and friends #39

Open
osrf-migration opened this issue Mar 13, 2019 · 3 comments
Open

Don't rely on gazebo.materials and friends #39

osrf-migration opened this issue Mar 13, 2019 · 3 comments

Comments

@osrf-migration
Copy link

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Several models in this repository make use of gazebo.materials, which is installed with Gazebo-classic.

This means these models are not easily portable to other software, like GzWeb and Ignition Gazebo.

I'd suggest we update all models in this repo, and consequently their copies in https://app.ignitionrobotics.org/fuel/models, to not rely on that file.

In the near-term, I'd suggest we:

  • Change all plain colors like Gazebo/Grey to use SDF material tags (ambient et. al.) instead.
  • Copy more complex materials like Gazebo/Wood into the models that use them

In the long term, considering that the support of Ogre materials in GzWeb is hacky and that Ignition Rendering is meant to be render-engine-agnostic, we should consider deprecating support for these files, or at least offering SDF-native ways of doing most of the things they do. I believe this ties to some of the PBR work being done right now.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


Agree that we should move away from relying on OGRE scripts in the long term, which means we'll need to start capturing more material parameters in SDF. There will be quite a few params to add and changes to make. It may not be completely compatible with SDF 1.6. This probably deserves a design doc.

I'd suggest we update all models in this repo

Just checking if we need to do this. Since we're porting the models from gazebo_models to fuel and eventually ignition libraries will be using fuel, we should only need to update the ones on fuel right?

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Yeah we only really need to change fuel, but since this repo will still be around for a while, I think it would be good to change it too, to decrease the diff between this and fuel, and so that users stop copying this pattern into new models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant