Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Subatlas functionality #278

Open
MikeGost opened this issue Nov 27, 2018 · 2 comments
Open

Refactor Subatlas functionality #278

MikeGost opened this issue Nov 27, 2018 · 2 comments
Assignees
@MikeGost
Labels
Enhancement

Comments

@MikeGost
Copy link
Contributor

Per discussion in PR #276, there are two ideas to try here:

  1. Would it ever be possible to have subAtlas(Polygon) call subAtlas(matcher) underneath? It feels like the should really do the same thing, but subAtlas(Polygon) is a convenience method.

  2. Does it make sense to have a subAtlas base class or interface? If 1 above can be done, there can be a default implementation for subAtlas(Polygon) and there could be a centralized source for logging and the packaging of the packed atlas.
@MikeGost MikeGost self-assigned this Nov 27, 2018
@jklamer
Copy link
Contributor

jklamer commented Nov 27, 2018

May I suggest a usage for https://github.com/osmlab/atlas/blob/dev/src/main/java/org/openstreetmap/atlas/utilities/filters/IntersectionPolicy.java? As the return value for different cut policies that can then be used by the the matcher when given a GeometricSurface(polygon).

@MikeGost
Copy link
Contributor Author

#334 partially addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeGost MikeGost

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jklamer @MikeGost