Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With 6.1.12 pressing on MapView Zoom controller +/- buttons generates LongPress events #1822

Open
wuan opened this issue Jul 1, 2022 · 8 comments · May be fixed by #1876
Open

With 6.1.12 pressing on MapView Zoom controller +/- buttons generates LongPress events #1822

wuan opened this issue Jul 1, 2022 · 8 comments · May be fixed by #1876

Comments

@wuan
Copy link

wuan commented Jul 1, 2022

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack

(feel free to delete whatever doesn't apply)

Issue Type

[ ] Question
[x] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[ ] Documentation

Description and/or steps/code to reproduce the problem

After upgrading to 6.1.12 using the Zoom controller buttons creates LongPress events after a zoom action is triggered, even when only clicking the zoom buttons.

Before 6.1.12 the Map view works as expected.

Environment

If it's a bug, version(s) of android this affects:

Currently tested on API 30 only

Version of osmdroid the issue relates to:

6.1.12
@wuan wuan changed the title With 6.1.12 pressing on Zoom controller +/- buttons generates With 6.1.12 pressing on MapView Zoom controller +/- buttons generates LongPress events Jul 1, 2022
@nienienienie
Copy link

isn't it related to #1572?

@InI4
Copy link

InI4 commented Jul 13, 2022

I'd like to confirm, that this issue persists with 6.1.13. Very annoying, when your application uses LongPress events.

@wuan
Copy link
Author

wuan commented Jul 15, 2022

The issue is also there when using 6.1.13.

@monsieurtanuki
Copy link
Collaborator

I've lost the track of what was in 6.1.12 and 6.1.13.
The good news is that you can copy and override custom zoom classes (and other classes too) to find the bug and fix it.
Feel free to send a PR then :)

@InI4
Copy link

InI4 commented Aug 26, 2022 •
edited

I can help with that, I still see that behaviour in 6.1.14. Being totally out of time: From the timeline and some superficial tests I'd say, it is the commit #1733. Can't you revert it?

@hauke96 hauke96 mentioned this issue Sep 25, 2022
Merged
@tvaknin
Copy link

tvaknin commented Nov 27, 2022

I found a workaround for now...

  1. Take time onZoom event
  2. on longPressHelper check if timediff>400ms -> do stuff

InI4 pushed a commit to InI4/osmdroid that referenced this issue Dec 21, 2022
Fixing bug/osmdroid#1822 avoiding recreation of bug/osmdroid#1775.
7f83eb4
@InI4 InI4 linked a pull request Dec 21, 2022 that will close this issue
Open
@hauke96 hauke96 mentioned this issue Jul 30, 2023
Open
@wuan wuan mentioned this issue Oct 8, 2023
Closed
@gokar96
Copy link

gokar96 commented Feb 7, 2024 •
edited

Any news here?

Issue is still in 6.1.18 and it is annoying because the workaround by tvaknin does not work when your are on the max or min zoomlevel (You get no OnZoom event in that case)

@gokar96
Copy link

gokar96 commented Feb 20, 2024

The best workaround for this problem is to create your own zoom buttons on the map :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing bug/#1822 avoiding recreation of bug/#1775. InI4/osmdroid
6 participants
@wuan @InI4 @monsieurtanuki @tvaknin @nienienienie @gokar96