Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable or disable the weather plugin #15789

Closed
Nine-Tailed opened this issue Nov 21, 2022 · 4 comments · Fixed by #19851
Closed

Enable or disable the weather plugin #15789

Nine-Tailed opened this issue Nov 21, 2022 · 4 comments · Fixed by #19851
Assignees
@0xRe1nk0
Labels
and-bugs
Milestone
4.8-android

Comments

@Nine-Tailed
Copy link
Contributor

Why do we need a weather confirmation dialog at all? When you press the turn off button in it, the indication of whether the plugin is enabled starts to work incorrectly.

Also, when the plugin is turned off, the corresponding item does not disappear from the map settings.

Screenrecorder-2022-11-21-20-20-07-733.mp4

Your Environment

OsmAnd Version: OsmAnd~ 4.3.0#13962mqta, Дата выпуска: 2022-11-21
Android version: 12
Device model: poco f3
@vshcherb vshcherb modified the milestones: 4.4-backend, 4.4-android Nov 21, 2022
@Zirochkabila
Copy link
Collaborator

OsmAnd~ 4.3.0#13973mqta, released: 2022-11-25
logcat (25).log

Perhaps the point is this
Screenshot 2022-11-25 at 14 59 10

@vshcherb
Copy link
Member

@Zirochkabila nope this is something else devonly

@Nine-Tailed
Copy link
Contributor Author

Nine-Tailed commented Nov 27, 2022 •
edited by DmitryAlexei

A similar problem in the plug-in external sensors.
I did not understand the purpose of the appearance of an additional dialog when these two plugins are enabled.

@vshcherb vshcherb modified the milestones: next-android, 4.8-android May 8, 2024
@vshcherb
Copy link
Member

vshcherb commented May 8, 2024 •
edited by 0xRe1nk0

To do:

  • For standard plugins confirmation is only needed if plugin adds or suggest to add anything like profile / routing etc (Nautical plugin for example is needed, Weather / External Sensors not needed)
  • Turn off button should disable plugin and update state of the screen but it doesn't now

@0xRe1nk0 0xRe1nk0 self-assigned this May 10, 2024
@0xRe1nk0 0xRe1nk0 linked a pull request May 13, 2024 that will close this issue
Fix update state on turn off button\show dialog only for plugins that… #19851
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xRe1nk0 0xRe1nk0

Labels
and-bugs
Projects
None yet
Milestone
4.8-android
Development

Successfully merging a pull request may close this issue.

Fix update state on turn off button\show dialog only for plugins that… osmandapp/OsmAnd
4 participants
@vshcherb @Nine-Tailed @0xRe1nk0 @Zirochkabila