Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallpaper not applied when file name begins with '#' #199

Open
1 task done
noyannus opened this issue May 20, 2023 · 2 comments
Open
1 task done

Wallpaper not applied when file name begins with '#' #199

noyannus opened this issue May 20, 2023 · 2 comments
Labels
bug:upstream stale Can't be fixed right now

Comments

@noyannus
Copy link
Contributor

noyannus commented May 20, 2023

Edited: Also when the filename contains the hash.

Describe the bug

When the name of a wallpaper .png contains a hash, the 'Apply' button does not apply it. Remove the '#', and it is applied.

Enabled plugins

What plugins did you have enabled? If not relevant, you can remove this.

  • Wallpaper

Affected versions

  • Yin-Yang version: 3.2 <= a more fine grained informative label on the application might be helpful.
  • Relevant application version:
  • Python version: Python 3.10.10
  • Qt Version: 5.15.9

Operating System: Manjaro Linux
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Kernel Version: 6.1.29-1-MANJARO (64-bit)
Graphics Platform: X11

@noyannus noyannus added the bug Something isn't working label May 20, 2023
l0drex added a commit that referenced this issue Jul 18, 2023
@l0drex
Copy link
Collaborator

l0drex commented Jul 18, 2023

I added a warning for the user that appears when they set the image path and each time they start the app with such a theme set in the wallpaper plugin.

The alternative would be to rename or copy and rename the copy of the file, but I don't really like that idea. What do you think?

@noyannus
Copy link
Contributor Author

The warning is enough to prevent trouble (and if not, it's the user's fault :-) ), and it does nothing automatically without the users's consent. I would go with that -- at least, until this sensitivity to #'s can be fixed.

l0drex added a commit that referenced this issue Nov 10, 2023
chase9 pushed a commit to chase9/Yin-Yang that referenced this issue Dec 18, 2023
@l0drex l0drex added bug:upstream stale Can't be fixed right now and removed bug Something isn't working labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:upstream stale Can't be fixed right now
Projects
None yet
Development

No branches or pull requests

2 participants