Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize themes (GTK or KDE or whatever) depending on their dominant (dark/light) #116

Open
bphd opened this issue Feb 16, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@bphd
Copy link

bphd commented Feb 16, 2022

It's relevant because a lot of software only listen to GTK/QT telling them that dominant is dark/light. And some light themes gives dark variable (Fluent...) and contrary too (Adwaita-dark, Sweet Mars...)

Maybe better, only permit dark dominant themes to be applied in the dark part and same for light

@l0drex
Copy link
Collaborator

l0drex commented Feb 16, 2022

You mean, we should only show light themes in the light combo box and only dark themes in the dark combo box?

This is really hard to do properly, however we could guess this based on the theme name.

@l0drex l0drex added the enhancement New feature or request label Feb 16, 2022
@bphd
Copy link
Author

bphd commented Feb 16, 2022

It's not that hard to do properly, because I just told that there is actually a dominant variable in the theme that GTK/QT gives to software for them to work with. You only have to find out where it is and define filtering with that. Filtering with theme name is impossible, because few of them use "dark/light" in their name

And maybe a checkbox to stop that filtering for fools over there and here who want to mix dominant at their risk

@bphd
Copy link
Author

bphd commented Feb 16, 2022

For example Firefox listen to that variable to set it's own theme on the "auto" theme. So you could search for what Firefox read in that case. That would be the variable to filter

@bphd
Copy link
Author

bphd commented Feb 19, 2022

VSCode too can detect this variable for example (maybe it's another one, in that case you should use both because it's different variable depending of KDE/Wayland/X11/GTK/QT... and it will permit you to know on what filter each category in the list)

@l0drex l0drex added this to To do in Yin-Yang features Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants