Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security crypto deprecation #31

Open
seve-andre opened this issue May 4, 2024 · 3 comments
Open

Security crypto deprecation #31

seve-andre opened this issue May 4, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@seve-andre
Copy link

Following security crypto deprecation mentioned here and here, io.github.osipxd:encrypted-datastore should probably be preferred over io.github.osipxd:security-crypto-datastore.

@osipxd
Copy link
Owner

osipxd commented May 4, 2024

Wow. Thank you for letting me know. They've deprecated this library six months ago, and the only public notice about this change is the line in documentation you've mentioned. Nothing on the library page, nothing in security guidelines where security-crypto is still stated as "the preferred way" to encrypt data.

It looks like I should drop dependency on security-crypto and provide some migration mechanism to not lose data encrypted with it. However, I don't want to rush because it's important for me to understand why they've deprecated security-crypto.

@osipxd osipxd self-assigned this May 5, 2024
@seve-andre
Copy link
Author

I completely understand your point of view. It's frustrating when important changes aren't communicated clearly. It's wise to take time to understand why security-crypto was deprecated before making any big moves. Thank you for your work!

@osipxd
Copy link
Owner

osipxd commented May 16, 2024

I don't think it's possible to get any information from the Android team. The security-crypto issue tracker seems to be inactive. So, I've decided to remove security-crypto from the dependencies, but keep using a key specification similar to the one used in security-crypto to maintain backward compatibility.

@osipxd osipxd added enhancement New feature or request labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants