Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ds annotation tck] ServiceSingleton and ServiceBundle using deprecated / invalid combination for DS > 1.2 but do not declare a namespace #636

Open
laeubi opened this issue Nov 20, 2023 · 0 comments
Open

[ds annotation tck] ServiceSingleton and ServiceBundle using deprecated / invalid combination for DS > 1.2 but do not declare a namespace #636

laeubi opened this issue Nov 20, 2023 · 0 comments
Assignees
@laeubi

Comments

@laeubi
Copy link
Contributor

laeubi commented Nov 20, 2023

ServiceSingleton has the following declaration

osgi/org.osgi.impl.bundle.component.annotations/src/org/osgi/impl/bundle/component/annotations/ServiceSingleton.java

Line 30 in 8ab4f46

@Component(name = "testServiceSingleton", scope = ServiceScope.SINGLETON, servicefactory = true)

ServiceBundle has the following declaration

osgi/org.osgi.impl.bundle.component.annotations/src/org/osgi/impl/bundle/component/annotations/ServiceBundle.java

Line 30 in 8ab4f46

@Component(name = "testServiceBundle", scope = ServiceScope.BUNDLE, servicefactory = false)

PDE DS cheecker correctly complains that this is a deprecated feature for DS > 1.2

Javadoc says @deprecated Since 1.3. Replaced by {@link #scope()}., further on it says This element is ignored when the {@link #scope()} element does not have the default value

So it seems these testcase should actually declare xmlns = "http://www.osgi.org/xmlns/scr/v1.2.0" (but then scope would not be valid) or remove the servicefactory or been duplicated into one pre-1.3 (without scope) and one post-1.2 (without servicefactory) case to generate.
@laeubi laeubi mentioned this issue Nov 20, 2023
Merged
laeubi added a commit to laeubi/eclipse.pde that referenced this issue Jan 15, 2024
@laeubi
Don't print markers to not pollute the maven logs
42e1023 
Currently there are validation errors because of
osgi/osgi#636

This disables the output to not pollute the log with messages not
realted to the test.
@laeubi laeubi mentioned this issue Jan 15, 2024
Merged
laeubi added a commit to eclipse-pde/eclipse.pde that referenced this issue Jan 15, 2024
@laeubi
Don't print markers to not pollute the maven logs
8fbf299 
Currently there are validation errors because of
osgi/osgi#636

This disables the output to not pollute the log with messages not
realted to the test.
@laeubi laeubi changed the title [ds-tck] ServiceSingleton and ServiceBundle using deprecated / invalid combination for DS > 1.2 but do not declare a namespace [ds annotation tck] ServiceSingleton and ServiceBundle using deprecated / invalid combination for DS > 1.2 but do not declare a namespace Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laeubi laeubi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laeubi